Skip to content

Plot each MATLAB quality history using its actual iteration count - #813

Merged
AnderBiguri merged 1 commit into
CERN:masterfrom
liu005:pr/matlab-quality-histories-20261110
Nov 10, 2026
Merged

AnderBiguri merged 1 commit into
CERN:masterfrom
liu005:pr/matlab-quality-histories-20261110

Conversation

@liu005

@liu005 liu005 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

The MATLAB quality demo concatenates metric histories and pads only SART to the OS-SART length. This fails when algorithms produce histories of different lengths, for example when SIRT stops earlier or SART runs longer than OS-SART.

Plot each algorithm's metric row against its own iteration indices. Keep the metric titles and algorithm legends without padding or assuming equal history lengths.

Validation: a live MATLAB R2020a regression executes the plotting section with four permutations of unequal histories, including an empty history. Upstream aea5346 fails with a concatenation-dimension error; the fixed version passes checks of plotted values, metric rows, labels and iteration indices. This is a CPU plotting regression, not a CUDA reconstruction test.

@AnderBiguri
AnderBiguri merged commit 89d2928 into CERN:master Nov 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants